Find/replace overlay: allow pasting in multi-page editors #2509 #2516
Conversation
|
@HannesWell what do you think? |
Test Results 1 821 files + 1 821 1 821 suites +1 821 1h 55m 12s ⏱️ + 1h 55m 12s For more details on these failures, see this check. Results for commit 5c7a21c. ± Comparison against base commit 64af72a. ♻️ This comment has been updated with latest results. |
...kbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
...kbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
…tform#2509 While actions of the target editor are properly deactivated when the target is an ordinary, single-page editor, the same does not happen when the target is a multi-page editor. In consequence, for example, you cannot paste clipboard content into the overlay via the according keyboard shortcut (CTRL+V), but it will paste into the target editor instead. With this change, the functionality to deactivate target editor actions is extended to also deactivate the relevant global actions (cut, copy, paste, etc.) that editors like multi-page editors fall back to. Fixes to eclipse-platform#2509
HeikoKlare
force-pushed
the
issue-2509-2
branch
from
26e31ce
to
5c7a21c
Compare
|
Thank you for the feedback and the approval, Hannes! By accident, I had to search through several Manifests right after proposing this PR and experienced how annoying the issue is. Seems like I had no need to search in Manifests for quite a while. So now I definitely agree that this should have high priority and that it should go into the upcoming release. |
Yes, absolutely 😅 |
|
Failing test is unrelated: #370 |
While actions of the target editor are properly deactivated when the target is an ordinary, single-page editor, the same does not happen when the target is a multi-page editor. In consequence, for example, you cannot paste clipboard content into the overlay via the according keyboard shortcut (CTRL+V), but it will paste into the target editor instead.
With this change, the functionality to deactivate target editor actions is extended to also deactivate the relevant global actions (cut, copy, paste, etc.) that editors like multi-page editors fall back to.
Fixes to #2509
Note
I hope there is a better solution to deactivate the according action handlers in a multi-page editor than this, but I did not find it so far. Still, I think this is better than not being able to use common shortcuts for cut, copy, paste etc. when using multi-page editors.
Behavior
Without the fix:
With the fix:
