-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving TabFolderLayout into SWT. #2186
Conversation
I don't see the relation to that issue. Can you pls. explain? |
I fixed the link, it is meant to be |
We can’t just delete it can we? It’s API. |
Its internal ... but I suspect there might be (internal) references that needs updates? |
Sorry I missed the internal in the package name. |
Definitely there would be some references as per my expectation. But how can i know where all it is referring? and what all files needs the respective updates. Could someone point me to a file which lists those failures or something? |
The best would be to first finish the SWT one so the new one is available. Then you can setup a platform-sdk-ide and use the usual "Find References" search, and replace all usages with the SWT one. |
Please make sure that the bundles require new enough swt that has that api. |
ad75d6b
to
3069cf4
Compare
@akurtakov : Can you please check now? I have updated bundle versions as well now. |
Jenkins fails due to OOM. I'm merging this one despite it. |
Moving TabFolderLayout into SWT.
Fixes eclipse-platform/eclipse.platform.swt#1317
This pr needs to be merged after eclipse-platform/eclipse.platform.swt#1402