Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving TabFolderLayout into SWT. #2186

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

deepika-u
Copy link
Contributor

@deepika-u deepika-u commented Aug 13, 2024

Moving TabFolderLayout into SWT.

Fixes eclipse-platform/eclipse.platform.swt#1317

This pr needs to be merged after eclipse-platform/eclipse.platform.swt#1402

@BeckerWdf
Copy link
Contributor

Fixes #1317

I don't see the relation to that issue. Can you pls. explain?

@laeubi
Copy link
Contributor

laeubi commented Aug 13, 2024

Fixes #1317

I don't see the relation to that issue. Can you pls. explain?

I fixed the link, it is meant to be

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 49m 15s ⏱️ - 7m 2s
 7 712 tests ±0   7 484 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 297 runs  ±0  23 550 ✅ +1  747 💤 ±0  0 ❌  - 1 

Results for commit 6bb53db. ± Comparison against base commit 0a3c1fd.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Aug 13, 2024

We can’t just delete it can we? It’s API.

@laeubi
Copy link
Contributor

laeubi commented Aug 13, 2024

Its internal ... but I suspect there might be (internal) references that needs updates?

@merks
Copy link
Contributor

merks commented Aug 13, 2024

Sorry I missed the internal in the package name.

@deepika-u
Copy link
Contributor Author

Its internal ... but I suspect there might be (internal) references that needs updates?

Definitely there would be some references as per my expectation. But how can i know where all it is referring? and what all files needs the respective updates. Could someone point me to a file which lists those failures or something?

@laeubi
Copy link
Contributor

laeubi commented Aug 13, 2024

The best would be to first finish the SWT one so the new one is available.

Then you can setup a platform-sdk-ide and use the usual "Find References" search, and replace all usages with the SWT one.

@akurtakov
Copy link
Member

Please make sure that the bundles require new enough swt that has that api.

@deepika-u deepika-u force-pushed the 1317_ui branch 4 times, most recently from ad75d6b to 3069cf4 Compare October 24, 2024 11:30
@deepika-u
Copy link
Contributor Author

@akurtakov : Can you please check now? I have updated bundle versions as well now.

@akurtakov
Copy link
Member

Jenkins fails due to OOM. I'm merging this one despite it.

@akurtakov akurtakov merged commit 3b49502 into eclipse-platform:master Oct 24, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TabFolderLayout into SWT and set it as a default in TabFolder
5 participants