Disable browser tests for Edge that are incompatible with WebView #671 #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipse-platform#671 Browser tests are currently not executed for the Edge browser on Windows. Some of the existing tests are not working for Edge, as they make assumptions that are incompatible with WebView API (such as executing operations on the browser from within browser callback). In order to prepare the tests to be executed for Edge as well, this change disables the incompatible tests when being executed for Edge. Contributes to eclipse-platform#671
HeikoKlare
force-pushed
the
issue-671-partial
branch
from
f4e7311
to
af77834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser tests are currently not executed for the Edge browser on Windows. Some of the existing tests are not working for Edge, as they make assumptions that are incompatible with WebView API (such as executing operations on the browser from within browser callback).
In order to prepare the tests to be executed for Edge as well, this change disables the incompatible tests when being executed for Edge.
As a consequence, the browser test class can be executed with Edge browser set as default (
-Dorg.eclipse.swt.browser.DefaultType=edge) and should (usually) succeed. There are some timing issues that may lead to random failures, which is why the tests are currently not enabled for Edge by default as well (see #672). This PR is an extract of #672.Contributes to #671