Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce split packages in o.e.tests #2369

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

akurtakov
Copy link
Member

Split packages cause a lot of troubles and this is test harness code so it's better to live without them.

Split packages cause a lot of troubles and this is test harness code so
it's better to live without them.
@akurtakov
Copy link
Member Author

This should reduce the issues in #2335 .
It should also serve as pre-req for #2368

@akurtakov akurtakov self-assigned this Sep 20, 2024
@akurtakov akurtakov merged commit 6e6a136 into eclipse-platform:master Sep 20, 2024
4 checks passed
@jukzi
Copy link
Contributor

jukzi commented Sep 23, 2024

@akurtakov
now some tests fail in i-Build
https://download.eclipse.org/eclipse/downloads/drops4/I20240923-0040/testresults/html/org.eclipse.osgi.tests_ep434I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html

And locally trying to reproduce i run into this:

!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.core.tests.harness [9]
  Unresolved requirement: Require-Bundle: org.eclipse.test.performance
    -> Bundle-SymbolicName: org.eclipse.test.performance; bundle-version="3.20.300.qualifier"; singleton:="true"
       org.eclipse.test.performance [10]
         Unresolved requirement: Import-Package: org.eclipse.test

	at org.eclipse.osgi.container.Module.start(Module.java:493)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel$2.run(ModuleContainer.java:2102)
	at org.eclipse.osgi.internal.framework.EquinoxContainerAdaptor$1$1.execute(EquinoxContainerAdaptor.java:143)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2093)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:2033)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1996)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1912)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:341)

when launching PlatformURLSessionTest

reverting this PR makes the test happy again.

@akurtakov
Copy link
Member Author

I will look into it tomorrow as it's public holiday here.

@jukzi
Copy link
Contributor

jukzi commented Sep 23, 2024

happy

  • King's Birthday - Australia
  • Day off for Independence Day - Bulgaria
  • Blessed Rainy Day - Bhutan
  • Kwame Nkrumah Memorial Day observed - Ghana
  • Autumn Equinox observed - Japan
  • Baptism of the Prophet - Mali
  • South Canterbury Anniversary Day - New Zealand
  • Saudi National Day - Saudi Arabia
  • Slovenian Sports Day - Slovenia
  • American Indian Day - United States

@merks
Copy link
Contributor

merks commented Sep 23, 2024

I wonder if perhaps we should just try to remove the package import that's being complained about:

image

After all, the org.eclipse.test bundle is required and it exports that package:

image

Maybe I should try that simple change?

@akurtakov
Copy link
Member Author

I would be very thankful if you try it.

merks added a commit to merks/eclipse.platform.releng.aggregator that referenced this pull request Sep 23, 2024
- It already requires bundle org.eclipse.test so the import seems
redundant and causes problems running tests.

eclipse-platform#2369
@iloveeclipse
Copy link
Member

I've created ticket to work on: eclipse-platform/eclipse.platform#1564.
Note, there are also ~100 osgi test failures that seem to be closely related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants