Don't use API-Tools from I-Builds for API checks in verification builds #2327
Conversation
|
To better understand the proposal: Why shouldn't I-Builds perform API checks? That sounds unintuitive to me. And note that (in my understanding) this change will not fix the issues metioned in eclipse-pde/eclipse.pde#1396 |
I builds perform API check (but in a different way), but we are currently using the I-Build Results to run the api-checks in verification checks. No there is a binary incompatibility, this does not work as Tycho was compiled against the previous code-base. |
|
Thank you for clarification. Now I understand the purpose. Then only the commit message is misleading, since you can read it as "with this change, we do not make API checks in I-Builds (anymore)" (like I did). |
|
For our fork of JDT in https://github.com/eclipse-jdtls/eclipse-jdt-core-incubator/ , which has PR rebased on top of master, we see some related failures. Are all platform builds currently broken too? |
|
Yes, all platform builds are currently broken. |
... if the use the |
Instead use the API-tools version Tycho is compiled against to avoid being affected from binary incompatibilities of internal methods.
HannesWell
force-pushed
the
dont_use_ibuild_for_api_checks
branch
from
81562e4
to
9958709
Compare
HannesWell
changed the title
I just updated the commit message of this change to hopefully make this more clear. With that I think we should apply this because the current situation there is a very tight dependency loop between Tycho and the PDE API-tools that make it hard to evolve methods that are internal in API-Tools (in defense of Tycho the API tools currently don't provide a proper API just an internal provisional API). So lets have this and see if this solves the issue. |
|
The latest build of that PDE PR eclipse-pde/eclipse.pde#1397, which uses the api-checks profile, succeeded without a problem. |
No description provided.