-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Run Eclipse-SDK aggregator build with multiple threads #2146
[Build] Run Eclipse-SDK aggregator build with multiple threads #2146
Conversation
f954f36
to
29ec169
Compare
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
I think the problem is that some dependencies aren't resolving at all not that there are actual license dependencies with 3rd party libraries:
|
In the verification builds of this PR using I assume the additional Maven-dependency of
This warning is also present for the current master build, therefore I assume it is unrelated. But since we probably cannot anything here, do you mind if I submit this now and we await the resolution of the vetting issue, wherever it happens? |
29ec169
to
550640d
Compare
@@ -1,2 +1,2 @@ | |||
-XX:+PrintFlagsFinal | |||
-Xmx2G | |||
-Xmx3G |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest verification build ran out of heap space. Looks like a build with multiple threads needs more RAM (not really a surprise).
Since we are running on the large 8GB executors since #2148, I think 3GB should not be a problem.
I don't think we should let glitches like this hold stuff up so I suggest we merge this when the build is good. |
Then lets try this. Anyway I think it's worth trying it out and if it eventually does not give sufficient speed-ups or causes too much trouble we can still revert it. |
In the I-build that contained this the Maven build stage took only 24min instead of ~40min. Five days ago, before the signing problem was addressed it took often more than two hours. |
This hopefully reduces the runtime of the build. Since no tests are run in these builds, I hope there are no interference problems.