Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install available sources with the SDK product #1800

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Feb 12, 2024

Currently only some sources are included in the SDK product these are those that explicitly specified in source features. As removing more and more third party dependencies from features, they will also vanish from source features and therefore missing in the SDK product. Beside that, managing source features itself is a tedious task.

This enables the <installSources> option for the SDK product that will install any available source with a bundle automatically.

grafik

FYI @merks @iloveeclipse

Fix #1767

Currently only some sources are included in the SDK product these are
those that explicitly specified in source features. As removing more and
more third party dependencies from features, they will also vanish from
source features and therefore missing in the SDK product. Beside that,
managing source features itself is a tedious task.

This enables the <installSources> option for the SDK product that will
install any available source with a bundle automatically.
@laeubi
Copy link
Contributor Author

laeubi commented Feb 12, 2024

Technically this adds <property name="org.eclipse.update.install.sources" value="true"/> to the profile, that means if one installs additional software into the SDK and the updatesite is using a recent P2/Tycho even these sources will be installed along with the product.

Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very promising. https://download.eclipse.org/eclipse/downloads/drops4/I20240211-1800/buildlogs/reporeports/reports/versionChecks.html (with the correct new Ibuild) is what should be checked to verify what has been added.

@akurtakov
Copy link
Member

I'm merging this one as we are getting close to M3 and with the comparator issues on last 2 I-build there would hoepfully be extra I-build today.

@laeubi
Copy link
Contributor Author

laeubi commented Feb 12, 2024

@akurtakov I didn't see this comparator erros in verification builds, so probabbly a compiler change that needs deployment of new compiler as well.

@akurtakov akurtakov merged commit 867f22b into eclipse-platform:master Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ASM source bundles in SDK
2 participants