Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace co-located to the installation by default for SDK-products #1484

Closed

Conversation

HannesWell
Copy link
Member

As suggested in #1459 (comment), this is a suggestion to use as default for the workspace a directory colocated to the installation instead of ${user.home}/workspace.

What do you others think?

We use that configuration for our products and it works well on Windows and Linux but since we don't provide Mac build I cannot tell how that setting works there.

@merks
Copy link
Contributor

merks commented Oct 28, 2023

Do you know what the impact this will have? I.e., will the workspace prompt dialog just be empty rather than coming up with a default? Is that actually a good thing? How does that correspond to the title of the PR because for that taken literally, I have this concern:

#1459 (comment)

@laeubi
Copy link
Contributor

laeubi commented Oct 28, 2023

What do you others think?

I think that the Workspace does not belongs to the installation at all, I have wiped a lot of eclipse installs over time but never wanted to loose my workspace.

@iloveeclipse
Copy link
Member

${user.home}/workspace is writable by default. Location next to install location can be read only if install was done by the admin user. e.g. All rpm based installations are done with root rights on root owned directories. No one regular user will be able to create workspace there.

So please let the default be as it was, it was chosen for a good reason.

@HannesWell
Copy link
Member Author

Do you know what the impact this will have? I.e., will the workspace prompt dialog just be empty rather than coming up with a default?

No, the prompt will not be empty, when launching the Product the first time after e.g. after unzipping it, the dialog suggest a folder named workspace in the installation folder (in this case extracted the zip in my Downloads folder):

grafik

Is that actually a good thing? How does that correspond to the title of the PR because for that taken literally, I have this concern:

#1459 (comment)

That's of course the question, but looking at your and the other answers it looks like for most the answer is no.
So I think this proposal does not make it -> Closing.

@HannesWell HannesWell closed this Oct 28, 2023
@HannesWell HannesWell deleted the colocated_workspace branch October 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants