Do not hide init errors in BundleComponent #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 273 files ±0 273 suites ±0 1h 11m 31s ⏱️ + 10m 40s For more details on these errors, see this check. Results for commit 17ccaed. ± Comparison against base commit 540c9ef. ♻️ This comment has been updated with latest results. |
Currently BundleComponent do not propagate errors but only log them, this can lead to a situation where it is unclear what calls fails. This changes the init method to throw an CoreException in all cases where it encounters a problem and instead use dedicated catch whenever it seems suitable. See eclipse-pde#553
laeubi
force-pushed
the
dont_hide_errors_on_init
branch
from
c426038
to
17ccaed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BundleComponent do not propagate errors but only log them, this can lead to a situation where it is unclear what calls fails.
This changes the init method to throw an CoreException in all cases where it encounters a problem and instead use dedicated catch whenever it seems suitable.
See #553