Draft: Add support for PyOpenSSL in paho.mqtt.python #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walter BONETTI <[email protected]>
IniterWorker
force-pushed
the
feature/pyopenssl-context
branch
from
2b7eaa7
to
1b2d5e4
Compare
Signed-off-by: Walter BONETTI <[email protected]>
IniterWorker
force-pushed
the
feature/pyopenssl-context
branch
from
ba24c43
to
02b583c
Compare
Signed-off-by: Walter BONETTI <[email protected]>
SSL.ZeroReturnError is raised when the connection has been closed cleanly, and no more data will be received. This behavior indicates that the connection is no longer usable and thus can be considered a type of connection error. Therefore, it is appropriate to raise a ConnectionError when encountering SSL.ZeroReturnError.
Signed-off-by: Walter BONETTI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce support for PyOpenSSL in the
paho.mqtt.pythonlibrary. The primary focus is on enabling the provision of a customSSL.Contextwithin the MQTT client. This enhancement is essential for ensuring compatibility with PKCS#11, as discussed in issue #646.Changes:
SSL.Contextwithin the MQTT client.tls_set_contextmethod to facilitate compatibility with bothssl.SSLContextandSSL.Context.Purpose:
The introduction of PyOpenSSL support serves to broaden the library's compatibility spectrum, particularly for scenarios involving PKCS#11 integration. This enhancement enhances the versatility and usability of the
paho.mqtt.pythonlibrary.Related Issue:
Related Work:
Notes for Reviewers:
Your feedback on the implementation approach and any suggestions for further improvements are highly appreciated.