Correctly mark connection as broken on SSL error and don't crash loop_forever #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been running this a few days including a few netflakes and my client is connected. I can't prove it is right but I lean to merging it. |
PierreF
force-pushed
the
catch-ssl-error
branch
2 times, most recently
from
223804c
to
f0e63d2
Compare
|
I've made a revert on Websocket wrapper connection due to issue catched during additional tests (f0e63d2). |
Previous commit catcher wider exception in WebsocketWrapper (OSError), which include temporary error like BlockingIOError, SSLWantReadError... This caused Websocket connection to break and cause client reconnection when it should only cause a later retry. Revert to catching previous ConnectionError, which should be fine, other fatal error like SSLEOFError that might happen would still be catched by caller (_sock_recv) which will take care of closing the websocket connection
PierreF
force-pushed
the
catch-ssl-error
branch
from
f0e63d2
to
8fa8596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch all OSError as indicator of connection broken. It should especially include SSL error. Also make WebsocketConnectionError a subclass of ConnectionError (which is a subclass of OSError).
Should fix #750.