Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties to access Client attributes #794

Merged
merged 8 commits into from
Jan 21, 2024
Merged

Add properties to access Client attributes #794

merged 8 commits into from
Jan 21, 2024
+381 −51

Commits on Jan 21, 2024

  1. Add properties to access Client attributes

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    cc63088 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aarni Koskela <[email protected]>
    @PierreF @akx
    PierreF and akx committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    e131bcb View commit details
    Browse the repository at this point in the history

  3. Use RuntimeError for unsupported feature rather than warnings

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    6280ae5 View commit details
    Browse the repository at this point in the history

  4. Fix review comments

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    fd08b21 View commit details
    Browse the repository at this point in the history

  5. Fix typing

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    818c857 View commit details
    Browse the repository at this point in the history

  6. Add more connection state 

    It's now possible to known when client is connecting/connected
and disconnecting/disconnected.
The difference between the two state is mostly whether the connection
is opened or not.
This will allow to avoid a reconnection while a reconnection is ongoing.
    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    8e091ff View commit details
    Browse the repository at this point in the history

  7. Disallow changing connection properties while connected

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    79acb4b View commit details
    Browse the repository at this point in the history

  8. Add note about possible breaking change

    @PierreF
    PierreF committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    c713c57 View commit details
    Browse the repository at this point in the history