-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test on newer Pythons; enable Python dev mode #771
Conversation
55efbc4
to
fea2a25
Compare
@PierreF Rebased, ready for review. |
ed52025
to
58a8142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the addition of PYTHONDEVMODE
-- Cool!
The PR looks fine, we just broke "python setup.py test" command. |
https://setuptools.pypa.io/en/latest/deprecated/commands.html
|
Yeah, breaking |
Confirmed that setup.py is not used for release, at least not how I do release (which I should document somewhere). My process is currently:
Therefor this PR seems fine for me. |
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
Co-authored-by: Christian Clauss <[email protected]> Signed-off-by: Aarni Koskela <[email protected]>
58a8142
to
88c8e72
Compare
If it helps, the procedure I've built for python-babel is pretty slick these days – everything is done on GitHub Actions, and I just okay the release (via the |
That true that making a release on CI is better than locally, as it ensure your local environment don't affect the release. I take not of your workflow and will consider it. |
See https://docs.python.org/3.12/library/devmode.html#devmode for what
PYTHONDEVMODE
does.