Async sample callback context fix. #1382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing MQTTAsync sample callback context: within the callback, the context is casted to the client handle but configured as 'NULL'. This causes a crash when the connection is lost.
Repro steps
Set a breakpoint in
onConnect
In another terminal:
netstat | grep 1883 tcp 0 0 mydevstation:32132 137.135.83.217:1883 ESTABLISHED sudo ss -K dst 137.135.83.217 dport = 1883
Expected: sample reconnects (
connlost
is called).Actual: crash in
MQTTAsync_connect
asclient
is NULL.