Release memory of pack->topic together with pack witin error cases of…

… MQTTPacket_publish() As seen in #1518 the memory allocated for pack-topic were not released in all cases. Signed-off-by: Juergen Kosel <[email protected]>
eclipse-paho · Sep 3, 2024 · 27fb21e · 27fb21e
1 parent 0521dc5
commit 27fb21e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/MQTTPacket.c b/src/MQTTPacket.c
@@ -575,6 +575,8 @@ void* MQTTPacket_publish(int MQTTVersion, unsigned char aHeader, char* data, siz
 	{
 		if (enddata - curdata < 2)  /* Is there enough data for the msgid? */
 		{
+			free(pack->topic);
+			pack->topic = NULL;
 			free(pack);
 			pack = NULL;
 			goto exit;
@@ -589,6 +591,8 @@ void* MQTTPacket_publish(int MQTTVersion, unsigned char aHeader, char* data, siz
 		pack->properties = props;
 		if (MQTTProperties_read(&pack->properties, &curdata, enddata) != 1)
 		{
+			free(pack->topic);
+			pack->topic = NULL;
 			if (pack->properties.array)
 				free(pack->properties.array);
 			if (pack)