Provide a way to identify operations that should not be retried #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnureddy17
approved these changes
Jan 13, 2024
| if err := entry.Remove(); err != nil { | ||
| c.errors.Printf("error removing queue entry: %s", err) | ||
| } | ||
| // Need a way to notify the user of this |
There was a problem hiding this comment.
I think having a callback for PublishViaQueue would be useful so the user can be notified. That same callback could be passed to the call to PublishWithOptions if/when callbacks are added for async published in paho
There was a problem hiding this comment.
Agreed - but I think that can be added at a later date (I think this should be done as part of #216; the idea being that the callback should be called whenever the publish is complete whether successfully or stopped due to error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial solution to issue #214 (the autopaho queue would loop infinitely attempting to resend invalid messages). Further work is needed, but this deals with the main issue.
Ref #214