-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC Timout request and prevent blocking while waiting response #107
Add RPC Timout request and prevent blocking while waiting response #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR - I have added a few comments. Please note that you will need to complete the CLA (see contributingh.md) before this can be accepted (this process ensures that we have verification that all contributions are correctly licensed).
hi @MattBrittan , thank you for your review. I got the following error message:
|
I have manually checked and the ECA system does not appear to have your address on file (note that email addresses used in Github are publicly available and easily retrieved from the patch). Can you please confirm that you have created an account and signed the ECA? I'm OK with the PR itself (but unfortunately cannot accept it until we get the ECA sorted). Personally I'd probably just return the |
…' of github.com:yogihardi/paho.golang into feature/add_timeout_and_prevent_blocking_on_rpc_request * 'feature/add_timeout_and_prevent_blocking_on_rpc_request' of github.com:yogihardi/paho.golang: fix git username and email for ECA validation
closes #108
--
this PR is related to this request #98
I found that there are missed fixes from the last PR on the following line
https://github.com/eclipse/paho.golang/blob/e818d6af9263c1ff1c68749d9e87defb8f51690f/paho/extensions/rpc/rpc.go#L76
also, I proposed request timeout on RPC Request