-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-agentpath: libraries require no path/name decoration #20202
Conversation
6a561ba
to
c1b599c
Compare
I still think this is the wrong way to do this. Check for JVMTI capabilities, not a specific library name. |
This is a CRIU-specific use case, there is no JDWP debug agent specified pre-checkpoint, post-restore the user would like to enable debugging via a command line option in the restore option file such as
These agent platform dependent/independent names are the only input available at CRIU restore stage. |
For another CRIU case, the JDWP agent is specified pre-checkpoint which will enable debug support post-restore, the library name-checking GAC referred could be replaced with JVMTI capabilities which is to be addressed w/ #20204 |
c1b599c
to
871c309
Compare
871c309
to
8d2d8e3
Compare
The agent library specified via -agentpath: has an absolute path/name, it should not be decorated again during the agent library loading; For -agentpath: option in the restore option file, compare the actual platform-dependent library name. Signed-off-by: Jason Feng <[email protected]>
8d2d8e3
to
81662f5
Compare
Jenkins test sanity xlinux jdk21 |
I believe the sanity.functional failures are due to a mismatch between the JDK and the tests (since #19872 was merged). |
-agentpath:
libraries require no path/name decorationThe agent library specified via
-agentpath:
has an absolute path/name, it should not be decorated again during the agent library loading;For
-agentpath:
option in the restore option file, compare the actual platform-dependent library name.Related
closes #20194
Signed-off-by: Jason Feng [email protected]