Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

romToRam cache follow up #20196

Merged
merged 2 commits into from
Sep 24, 2024
Merged

romToRam cache follow up #20196

merged 2 commits into from
Sep 24, 2024

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Sep 19, 2024 •
edited
Loading

  • Declare variables first in romToRam entry removal
  • Correctly free romToRam hash table and mutex

#20169 (comment)

Port to 0.48: #20197

@theresa-m theresa-m mentioned this pull request Sep 19, 2024
Merged
keithc-ca
keithc-ca requested changes Sep 19, 2024
View reviewed changes
runtime/util/hshelp.c Outdated Show resolved Hide resolved
@keithc-ca
Copy link
Contributor

Jenkins compile amac jdk21

@theresa-m theresa-m changed the title Declare variables first in romToRam entry removal romToRam cache follow up Sep 19, 2024
keithc-ca
keithc-ca requested changes Sep 19, 2024
View reviewed changes
runtime/shared_common/shrinit.cpp Outdated Show resolved Hide resolved
@theresa-m theresa-m force-pushed the findclass_cache_fix branch 2 times, most recently from 6984d60 to ca6fe7b Compare September 19, 2024 19:28
@theresa-m
Copy link
Contributor Author

I have confirmed that this fixes the previous failures http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=78298. Any other comments @keithc-ca ?

keithc-ca
keithc-ca requested changes Sep 20, 2024
View reviewed changes
runtime/shared_common/shrinit.cpp Outdated Show resolved Hide resolved
@keithc-ca
Copy link
Contributor

Jenkins test sanity.functional amac,win jdk21

@theresa-m
Copy link
Contributor Author

theresa-m commented Sep 23, 2024 •
edited
Loading

Except for maybe the timeouts in SCURLClassLoader* tests these failures appear to be known issues #19678 and #19408.

I'm rerunning windows sanity tests to check again https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/24027/

@pshipton
Copy link
Member

pshipton commented Sep 23, 2024 •
edited
Loading

Internal build (wa) passed http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=78507
wi also passed http://vmfarm.rtp.raleigh.ibm.com/tree_view.php?build_id=78510

@theresa-m theresa-m force-pushed the findclass_cache_fix branch 2 times, most recently from 092449d to 5711e61 Compare September 23, 2024 18:41
@theresa-m
Copy link
Contributor Author

theresa-m commented Sep 23, 2024 •
edited
Loading

I updated the changes based on the discussion #20196 (comment)

Windows Java 8 build started with these changes: http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=78528

@keithc-ca can you please start the pr builds with these changes?

@theresa-m
Free romToRam hash table and mutex
e45e46f 
Signed-off-by: Theresa Mammarella <[email protected]>
@keithc-ca
Copy link
Contributor

Jenkins test sanity.functional amac,win jdk21

@keithc-ca keithc-ca merged commit c683ed0 into eclipse-openj9:master Sep 24, 2024
7 checks passed
@pshipton pshipton mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangshao0 hangshao0 hangshao0 approved these changes

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
Release 0.48 (Java 8, 11, 17, 21, 23)...
Development

Successfully merging this pull request may close these issues.
4 participants
@theresa-m @keithc-ca @pshipton @hangshao0