Add native method stubs for jdk.jfr.internal.jvm #20053
Open
+620
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila FYI |
tajila
reviewed
Aug 23, 2024
thallium
force-pushed
the
jfr-internal-jvm
branch
from
9d000ae
to
77eefea
Compare
tajila
reviewed
Aug 27, 2024
| @@ -21,4 +21,69 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex | |||
| --> | |||
| <exports group="jfr"> | |||
| <export name="Java_com_ibm_oti_vm_VM_triggerExecutionSample" /> | |||
| <export name="Java_jdk_jfr_internal_JVM_registerNatives" /> | |||
There was a problem hiding this comment.
youll also need a objects.xml for UMA build system
There was a problem hiding this comment.
then youll need to update runtime/jcl/module.xml to add both the objects and the exports file
There was a problem hiding this comment.
Sorry for the late reply, I've done the changes
thallium
force-pushed
the
jfr-internal-jvm
branch
from
77eefea
to
ba26fd8
Compare
tajila
reviewed
Sep 19, 2024
| SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0 OR GPL-2.0-only WITH OpenJDK-assembly-exception-1.0 | ||
| --> | ||
| <objects group="jfr"> |
There was a problem hiding this comment.
should also have
<object name="Java_jdk_jfr_internal_JVM" >
<include-if condition="spec.flags.opt_jfr" />
</object>
tajila
reviewed
Sep 19, 2024
| @@ -65,6 +65,7 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex | |||
| <xi:include href="uma/se9_objects.xml"></xi:include> | |||
| <xi:include href="uma/se16_objects.xml"></xi:include> | |||
| <xi:include href="uma/se19_objects.xml"></xi:include> | |||
| <xi:include href="uma/jfr_objects.xml"></xi:include> | |||
There was a problem hiding this comment.
you need an entry in the objects list below as well
<group name="jfr">
<include-if condition="spec.flags.opt_jfr"/>
</group>
tajila
reviewed
Sep 19, 2024
thallium
force-pushed
the
jfr-internal-jvm
branch
2 times, most recently
from
2f123ed
to
95d5b08
Compare
Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
jfr-internal-jvm
branch
from
95d5b08
to
5fb7ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.