Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Subtract negative array header size from offset #19916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Jul 24, 2024

This restores the tree structure for non off-heap path. During refactoring for off-heap, the tree structure was accidentally changed to use addition instead of subtract. Reverting the change as there might be opts performing pattern matching against the original tree structure.

This restores the tree structure for non off-heap path. During
refactoring for off-heap, the tree structure was accidentally changed
to use addition instead of subtract. Reverting the change as there might
be opts performing pattern matching against the original tree structure.

Signed-off-by: Shubham Verma <[email protected]>
@VermaSh
Copy link
Contributor Author

VermaSh commented Jul 24, 2024

Depends on eclipse/omr#7405
cc: @r30shah / @zl-wang

@VermaSh
Copy link
Contributor Author

VermaSh commented Jul 24, 2024

Launched a new personal build with these changes.

@VermaSh
Copy link
Contributor Author

VermaSh commented Jul 31, 2024

Looking into the vm failure. Launched grinder for verification.

Interpreter crash
12:59:16  Unhandled exception
12:59:16  Type=Segmentation error vmState=0x00000000
12:59:16  J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
12:59:16  Handler1=000003FF8C2C9538 Handler2=000003FF8C1B1A60 InaccessibleAddress=0000000000000000
12:59:16  gpr0=000003FF11724B10 gpr1=000003FF88028B80 gpr2=0000000000000008 gpr3=0000000000000018
12:59:16  gpr4=000003FEDC149500 gpr5=0000000000000020 gpr6=0000000000000000 gpr7=000003FEAC0066C0
12:59:16  gpr8=000003FF11724E9A gpr9=000003FF4927E310 gpr10=0000000000000000 gpr11=000003FF4927E1E0
12:59:16  gpr12=000003FF66F9A108 gpr13=000003FF8C511F68 gpr14=000003FF8C353CB2 gpr15=000003FF4927DE78
12:59:16  psw=000003FF8C353CD0 mask=0705100180000000 fpc=00080000 bea=000003FF861B4204
12:59:16  fpr0=000003ff870a4ba8 (f: 2265598976.000000, d: 2.171921e-311)
12:59:16  fpr1=4032000000000000 (f: 0.000000, d: 1.800000e+01)
12:59:16  fpr2=000003ff88155404 (f: 2283099136.000000, d: 2.171930e-311)
12:59:16  fpr3=2020202020202020 (f: 538976256.000000, d: 6.013470e-154)
12:59:16  fpr4=bfdfc47d16901db4 (f: 378543552.000000, d: -4.963677e-01)
12:59:16  fpr5=a0c0a0c0a0c00000 (f: 2696937472.000000, d: -6.349662e-151)
12:59:16  fpr6=40288743fc3f7899 (f: 4232018176.000000, d: 1.226419e+01)
12:59:16  fpr7=0000000000000000 (f: 0.000000, d: 0.000000e+00)
12:59:16  fpr8=000003ff4923f000 (f: 1227091968.000000, d: 2.171408e-311)
12:59:16  fpr9=0000000000041000 (f: 266240.000000, d: 1.315400e-318)
12:59:16  fpr10=000003fec400af28 (f: 3288379136.000000, d: 2.170304e-311)
12:59:16  fpr11=0000000000000000 (f: 0.000000, d: 0.000000e+00)
12:59:16  fpr12=000003ff4927f900 (f: 1227356416.000000, d: 2.171408e-311)
12:59:16  fpr13=0000000000000001 (f: 1.000000, d: 4.940656e-324)
12:59:16  fpr14=000003ff4923f000 (f: 1227091968.000000, d: 2.171408e-311)
12:59:16  fpr15=000003ff30059a28 (f: 805673536.000000, d: 2.171200e-311)
12:59:16  Module=/home/jenkins/workspace/Test_openjdk11_j9_sanity.openjdk_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/lib/default/libj9vm29.so
12:59:16  Module_base_address=000003FF8C280000
12:59:16  Target=2_90_20240724_2196 (Linux 5.15.0-113-generic)
12:59:16  CPU=s390x (4 logical CPUs) (0x1f5c10000 RAM)
12:59:16  ----------- Stack Backtrace -----------
12:59:16  _ZN26VM_BytecodeInterpreterFull3runEP10J9VMThread+0xf40 (0x000003FF8C353CD0 [libj9vm29.so+0xd3cd0])
12:59:16  bytecodeLoopFull+0xee (0x000003FF8C352D7E [libj9vm29.so+0xd2d7e])
12:59:16  c_cInterpreter+0x64 (0x000003FF8C46EE8C [libj9vm29.so+0x1eee8c])
12:59:16  ---------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant