Add zNext support #7525
Open
Add zNext support #7525
+1,223
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in this commit adds support for zNext instructions as well as adds processor recognition and facility checks. Signed-off-by: Spencer Comin <[email protected]>
Emulating the instructions when support is not availble on hardware allows testing of exploitation that uses zNext instructions on older IBM Z hardware. Changes in this commits adds necessary changes for emulating zNext instructions. Signed-off-by: Spencer Comin <[email protected]>
Adds support for generating load indexed address instructions for the add tree in axaddEvaluator when the tree has the correct shape. Signed-off-by: Spencer Comin <[email protected]>
Changes in this commit adds exploitation of Count leading and trailing zeros on zNext for opcodes i/lnolz and i/lnotz respectively. Apart from using the zNext instructions for these opcodes, this commit also adds supporting changes to enable zNext emulation for these zNext instructions. Signed-off-by: Dhruv Chopra <[email protected]>
Accelerate Integer.expand, Integer.compress, Long.expand, and Long.compress using the BDEPG and BEXTG instructions in zNext. Signed-off-by: Spencer Comin <[email protected]>
Moving canEmulate enables us to check if emulation is enabled and if the instruction op code supports emulation through a single call. Signed-off-by: Shubham Verma <[email protected]>
Accelerate DAA ExternalDecimal.checkExternalDecimal api for verifying Zoned/External decimals using zNext instruction, Vector Test Zoned. This commit also includes changes required for generating Vector Test Zoned instruction. Signed-off-by: Shubham Verma <[email protected]>
|
@joransiu @0xdaryl Can we please get review on these changes ? This PR should be merge with OpenJ9 PR : eclipse-openj9/openj9#20507 |
|
I can review for general structural correctness, but for the actual architectural changes I will defer to Joran's expertise. |
| */ | ||
| bool yankIndexScalingOp() | ||
| { | ||
| return false; |
There was a problem hiding this comment.
This should probably return arch < zNext or check for LXA support instead of always returning false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR adds following supporting changes for zNext processor and its
exploitation.
-Adds support for generating load indexed address instructions for the
add tree in axaddEvaluator when the tree has the correct shape.
OpenJ9.