Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgconfig libdir #3150

Open
wants to merge 2 commits into
base: fixes
Choose a base branch
from

Conversation

nullr0ute
Copy link
Contributor

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

ralight and others added 2 commits October 31, 2024 23:02
In some distributions libraries are installed
into lib64 rather than lib for 64 bit architectures
so use the cmake variable like we already do
for the prefix to ensure that's correct for all
distributions.

Signed-off-by: Peter Robinson <[email protected]>
@ralight
Copy link
Contributor

ralight commented Oct 31, 2024

I understand the rationale, however at the moment the pure Makefile approach also installs the .pc files. This means there needs to be a string replacement when installing from Makefile otherwise it's completely broken there. Is there a better way of detecting the lib64 component?

@nullr0ute
Copy link
Contributor Author

I understand the rationale, however at the moment the pure Makefile approach also installs the .pc files. This means there needs to be a string replacement when installing from Makefile otherwise it's completely broken there. Is there a better way of detecting the lib64 component?

I missed that the Makefile approach stole CMake vars in that approach, will update the patch so both ways are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants