switch to orbit 2022-09 and widen version range for gson. See #611 #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
commented
Jul 9, 2022
| <unit id="com.google.gson" version="2.8.9.v20220111-1409"/> | ||
| <unit id="com.google.gson.source" version="2.8.9.v20220111-1409"/> | ||
| <unit id="com.google.guava" version="30.1.0.v20210127-2300"/> | ||
| <unit id="com.google.guava.source" version="30.1.0.v20210127-2300"/> | ||
| <unit id="jakarta.websocket" version="0.0.0"/> | ||
| <unit id="jakarta.websocket.source" version="0.0.0"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="false" type="InstallableUnit"> |
cdietrich
commented
Jul 19, 2022
releng/lsp4j-feature/feature.xml
Outdated
| @@ -31,7 +31,7 @@ | |||
| </license> | |||
|
|
|||
| <requires> | |||
| <import plugin="com.google.gson" version="2.8.9" match="equivalent"/> | |||
| <import plugin="com.google.gson" version="2.8.9" match="compatible"/> | |||
There was a problem hiding this comment.
i am not sure if we just should go to 2.9.0 as minimal version.
There was a problem hiding this comment.
@jonahgraham what do you think?
There was a problem hiding this comment.
Lets make 2.9.0 min version.
Signed-off-by: Christian Dietrich <[email protected]>
jonahgraham
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to orbit 2022-09 and widen version range for gson. See #611
unfortunately gson 2.9 is still not available in an orbit milestone. so i have to keep the 2.8.9 on p2 and the lower bound