Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version helper classes #1532

Closed
wants to merge 5 commits into from
Closed

Fix version helper classes #1532

wants to merge 5 commits into from

Conversation

gcx-seb
Copy link
Contributor

@gcx-seb gcx-seb commented Nov 3, 2023

I think the Version class has some issues which I tried to fix. I have added some test cases which fail without these changes. Feel free to have a look.

Also I think Version.V1_0, LwM2mVersion.V1_0 and LwM2mVersion.V1_1 should probably be final… so I changed that, too. Happy to hear your opinions.

@gcx-seb gcx-seb changed the title fix version helper classes Fix version helper classes Nov 3, 2023
@sbernard31
Copy link
Contributor

sbernard31 commented Nov 6, 2023 •
edited
Loading

That totally makes sense to me. 👍

sbernard31
sbernard31 reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@sbernard31 sbernard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except this last question.
I think we are good.

leshan-core/src/test/java/org/eclipse/leshan/core/VersionTest.java Outdated Show resolved Hide resolved
@sbernard31
Copy link
Contributor

About github-actions comments, if you don't want to deal with it, it's not a big deal. I can do it myself 🙂

sbernard31 pushed a commit that referenced this pull request Nov 8, 2023
@gcx-seb @sbernard31
GH-1532: Some Fix/Enhancement about Version class
cb204b2
@sbernard31
Copy link
Contributor

This now integrated in master (squashed in 1 commit cb204b2)
This will be available in next release (2.0.0-M14, see #1531)

@gcx-seb Thx a lot for you contribution 🙏

@sbernard31
Copy link
Contributor

@gcx-seb, could I ask how you are using Leshan ?

@gcx-seb
Copy link
Contributor Author

gcx-seb commented Nov 8, 2023

could I ask how you are using Leshan ?

Sure, nothing too fancy though… mainly just using leshan-server-cf for building LwM2M servers 🙂

@sbernard31
Copy link
Contributor

would you like to be added to Leshan adopters ?

@sbernard31
Copy link
Contributor

Implementing #1535, I found that String.split default behavior is a bit strange and so discover more issue about Version class that I fixed in 2efb924

@sbernard31
Copy link
Contributor

(I forgot to close this issue 🙂)

@sbernard31 sbernard31 closed this Nov 9, 2023
@gcx-seb
Copy link
Contributor Author

gcx-seb commented Nov 10, 2023

would you like to be added to Leshan adopters ?

Yes, we'd love to ❤️ I'll post in #830 👍

@sbernard31
Copy link
Contributor

@gcx-seb if you are OK I will create the PR to add you to : https://iot.eclipse.org/adopters/#iot.leshan

@gcx-seb
Copy link
Contributor Author

gcx-seb commented Nov 10, 2023

Just looking over https://iot.eclipse.org/adopters/#iot.leshan, we're also using Californium, hawkBit, Mosquitto and Paho.

@sbernard31
Copy link
Contributor

OK I will add it too. I let you know when the PR is ready (maybe not today)

@sbernard31
Copy link
Contributor

I created the corresponding PR : https://gitlab.eclipse.org/eclipsefdn/it/api/eclipsefdn-project-adopters/-/merge_requests/241

@sbernard31
Copy link
Contributor

(This is deployed : https://iot.eclipse.org/adopters/#iot.leshan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernard31 sbernard31 sbernard31 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcx-seb @sbernard31