Stabilize two test that seem to often fail on the CI #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Nov 10, 2024
org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/XMLAssert.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
stabilize_tests
branch
4 times, most recently
from
843f24a
to
1bcac1d
Compare
- Use a timeout instead of static wait times - retry diagnostics - use a copy of the current state Signed-off-by: Christoph Läubrich <[email protected]>
laeubi
force-pushed
the
stabilize_tests
branch
from
1bcac1d
to
0952504
Compare
|
Seems one need to sort out what is really "unexpected" here... some of the returned diagnostics do not look that wrong given other seem to be intermediates or even valid... I'll take a look later on this, but currently it makes contributions really hard if there are random failures. |
I understand that it is an annoying problem, this problem should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reduces the test time from 5 sec to less than a second for the