Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CacheResourcesManager Constructor used for test package protected #1702

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Nov 10, 2024

It looks like the CacheResourcesManager(Cache cache) constructor is oly used for test, so this is made package protected now.

This has the advantage that there is no public reference to google Cache API making it an internal implementation detail that can easily be exchanged (or embedded).

It looks like the CacheResourcesManager(Cache cache) constructor is oly
used for test, so this is made package protected now.

This has the advantage that there is no public reference to google Cache
API making it an internal implementation detail that can easily be
exchanged.

Signed-off-by: Christoph Läubrich <[email protected]>
@angelozerr angelozerr merged commit 0aadd16 into eclipse-lemminx:main Nov 10, 2024
4 of 6 checks passed
@angelozerr
Copy link
Contributor

Thanks @laeubi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants