Improve completion for annotation members #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix duplicates in annotation members - fix range for annotation members - fix type of annotation member completions - opening completion in a normal annotation or single value annotation before `(`, eg `@MyAnnota|tion(value = 1)`, now tries to complete the annotation name rather than the annotation members Fixes eclipse-jdt#930 Signed-off-by: David Thompson <[email protected]>
|
should fix a bit over 20 completion cases |
datho7561
deleted the
dom-with-javac-duplicate-annotation-member-completion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(, eg@MyAnnota|tion(value = 1), now tries to complete the annotation name rather than the annotation membersFixes #930