Fix some errors that occur when importing o.e.j.c incubator #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
commented
Oct 31, 2024
•
datho7561
commented
- Do not reuse the context when compiling to multiple output directories
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
d8a4690
to
f28c046
Compare
|
update: there should be no test regressions caused by this PR |
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
f28c046
to
afd7b17
Compare
|
Can you please split it into 2 distinct commits for each part of the change? I think the context bit is more risky than the problems mapping bit there are chances we'll have to revert it. Smaller commits allows less loss during reverts. |
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
afd7b17
to
58ba267
Compare
|
I created a separate PR for the problem id changes. |
|
test this please |
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
58ba267
to
28d3f16
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
2ad1e11
to
f45e071
Compare
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
28d3f16
to
410e5ac
Compare
org.eclipse.jdt.core.javac/src/org/eclipse/jdt/core/dom/JavacBindingResolver.java
Outdated
Show resolved
Hide resolved
mickaelistria
requested changes
Nov 13, 2024
There was a problem hiding this comment.
The JavacCompiler changes would fix #839 . Can you please move the probably unrelated part about bindings?
datho7561
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
410e5ac
to
f986cf0
Compare
mickaelistria
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
f986cf0
to
b491c7f
Compare
- Do not reuse the context when compiling to multiple output directories - Implement Alex's idea of a separate file of javac-specific error codes Signed-off-by: David Thompson <[email protected]>
mickaelistria
force-pushed
the
dom-with-javac-fix-oejc-import-problems
branch
from
b491c7f
to
816883c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.