Log type #851
Closed
Log type #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng import Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
- Also fix a mostly unrelated classcast exception Signed-off-by: David Thompson <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…-jdt#597) fix: eclipse-jdt#592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
Signed-off-by: David Thompson <[email protected]>
- Fixes error when executing cleanups in the Eclipse IDE - Cleanups still don't work (they don't do anything) Signed-off-by: David Thompson <[email protected]>
Fixes some problem ids, which should in turn fix some quickfixes in the jdtls suite. Signed-off-by: David Thompson <[email protected]>
Small fix to generic error range fixer as well: length should always be at least one so that the error is visible somewhere. Signed-off-by: David Thompson <[email protected]>
Should fix 3 tests Signed-off-by: David Thompson <[email protected]>
Signed-off-by: David Thompson <[email protected]>
…e-jdt#621) * Fix some bugs requiring == for multiple resolutions on a node Signed-off-by: Rob Stryker <[email protected]> * Cleanup Signed-off-by: Rob Stryker <[email protected]> --------- Signed-off-by: Rob Stryker <[email protected]> Co-authored-by: Rob Stryker <[email protected]>
Signed-off-by: David Thompson <[email protected]>
The main goal of this PR is to get the quick fix for the following case
working:
```java
public class MyClass extends java.util.List {
}
```
I needed to redo a lot of the type variable and method param/arg code in
order to accomplish this.
Signed-off-by: David Thompson <[email protected]>
* Report diagnostics for the unused imports & private members & local variables
- var in method without initializer (eg `var i;`) - attempt to invoke `.toString()` on a method that returns `int` Signed-off-by: David Thompson <[email protected]>
This reverts commit 27d1ddb. It causes many regressions on JDT-LS.
This reverts commit 2aa2631. Improve Lombok support by running analysis less greedily
This one deals mostly with explicit this param. Signed-off-by: David Thompson <[email protected]>
requires 1 VM arg per line
eg. preserve the `m[]` in the AST in the following case, (despite the fact that it's invalid), since javac does. ```java int[] foo = new int[m[]]; ``` Signed-off-by: David Thompson <[email protected]>
Skip in case we're running tests to remain compatible with JDT
…n count Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Javac sometimes add virtual nodes to the tree (usually with endPos == -1). Ignore then when computing diagnostic position.
Log instead
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
16bd705
to
9fb5696
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7b4b9ad
to
e230daa
Compare
rgrunber
force-pushed
the
dom-with-javac
branch
from
0575d89
to
6dd73f3
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
df710af
to
fbcc030
Compare
|
This was interesting once, but doesn't seem useful in general. Let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.