improve how method and variable positions names are resolved #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayanper
changed the title
gayanper
changed the title
|
@mickaelistria @datho7561 A small but skeptical fix which I really need your eyes on. |
gayanper
force-pushed
the
fix-name-positions
branch
from
0739982
to
27c79d1
Compare
|
Seems to add 76 failures. |
|
@mickaelistria is there a easy way to see the diff of failing tests with this PR ? I think i have to refine the fix. |
gayanper
force-pushed
the
fix-name-positions
branch
from
27c79d1
to
0ce7ac2
Compare
|
I refined the fix, @mickaelistria please have a look at. I also see that now failed method delta is -80ish. |
Comment on lines
943
to
957
| // int endPos = javac.getEndPosition(this.javacCompilationUnit.endPositions); | ||
| // if( !simpleName.toString().equals(FAKE_IDENTIFIER)) { | ||
| // char theChar = this.rawText.charAt(endPos); | ||
| // char soughtLastChar = simpleName.toString().charAt(simpleName.toString().length() - 1); | ||
| // while (endPos > res.getStartPosition() && theChar != soughtLastChar) { | ||
| // theChar = this.rawText.charAt(--endPos); | ||
| // } | ||
| // endPos++; | ||
| // int length = simpleName.toString().length(); | ||
| // if( endPos != -1 && endPos - length > 0) { | ||
| // simpleName.setSourceRange(endPos - length, length); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
I will remove it once all tests passes as the final step, Until I will keep this review open as a reminder.
|
Looks like it still adds 35 failures compared to https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/ |
mickaelistria
force-pushed
the
dom-with-javac
branch
from
f752b35
to
42d59cc
Compare
|
I'm getting The cause appears to be that the length of the name is non-zero, but the starting position is |
|
I suggest setting a break point on the two IllegalArgumentException throws in For instance, for constructors, the |
gayanper
force-pushed
the
fix-name-positions
branch
from
eece3fe
to
5469a34
Compare
|
@datho7561 @mickaelistria How do you run the tests locally for debugging, For example I tried to run a failing ASTConverter test in org.eclipse.jdt.core.tests.model but I get bunch of errors that I don't see in CI. basically regardless which branch I'm in they fail. |
|
Here's the config I use along with descriptions of the important parts
I run the
The runtime JRE must be Java 23. The Temurin build of Java 23 is not yet available (Java 23 is due in September I think), so I'm using the java.com early access build.
In the VM arguments, you must pass all the flags needed to enable the javac bits. The list of arguments is available in the pom.xml for the javac.tests project We should probably document this somewhere. |
|
@datho7561 thanks a lot for the details, I thought I might have to use the Eclipse IDE to run the tests, but I can get It working in VSCode as well, even individuals tests using PDE plugin. What was missing is the java module entries which I totally forgot about. |
gayanper
force-pushed
the
fix-name-positions
branch
from
197cacf
to
43b14a1
Compare
mickaelistria
merged commit ce7aa6c
into
eclipse-jdtls:dom-with-javac
2 of 3 checks passed
akurtakov
pushed a commit
that referenced
this pull request
Jul 19, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Jul 25, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Jul 25, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
akurtakov
pushed a commit
that referenced
this pull request
Jul 29, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
akurtakov
pushed a commit
that referenced
this pull request
Aug 16, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Sep 5, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Sep 10, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Sep 18, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Sep 24, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Sep 25, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Oct 15, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
rgrunber
pushed a commit
that referenced
this pull request
Oct 18, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Oct 23, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
mickaelistria
pushed a commit
that referenced
this pull request
Nov 12, 2024
fix: #592 * Use simple name length instead of javac node length. * consider the fake name and error names when calculating length. * skip error and fake identifier nodes from position update. * improve fix how position is calculated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592