Set a bunch of project encodings to UTF-8 #902
Conversation
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
There was a problem hiding this comment.
For what I see in ValidateProjectEncoding, the validation is applied in all projects in the workspace without making any distintion as to whether they are test projects or not.
Do you think these changes should be reverted? I think they don't really bother much and the warning just clutters the Problems view, that's why I applied the Quick Fix to all of them.
There was a problem hiding this comment.
The test projects modified here serve the purpose to be used in tests. If there are no test fails, why is the change needed? Usually, none of the projects here are imported in any development workspace.
There was a problem hiding this comment.
If there are no test fails, why is the change needed?
The idea is to declutter the Problems view and this is a low hanging fruit: it can be done easily with a Quick Fix and AFAICT it doesn't really break anything.
Usually, none of the projects here are imported in any development workspace.
I installed my IDE following the official instructions in Contributing.md and I got all those projects checked out, e.g. these JDT tests
There was a problem hiding this comment.
@merks : could you please check jdt ui setup? I assume it misses some filters.
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
There was a problem hiding this comment.
Please open an issue and assign it to me so that I/we don’t forget.
There was a problem hiding this comment.
Please open an issue and assign it to me so that I/we don’t forget.
@fedejeanne : would you please do that? I'm not using oomph, so I wouldn't be able to provide steps to reproduce or to validate the fix.
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
| @@ -0,0 +1,2 @@ | |||
| eclipse.preferences.version=1 | |||
There was a problem hiding this comment.
This is a test folder, why it is changed?
It was done using a "Quick Fix" and the value set (UTF-8) is the same value that any other project in the workspace uses. The objective of this commit is to declutter the "Problems" view.
fedejeanne
force-pushed
the
enhancements/set_project_encodings_to_utf8
branch
from
4e48780
to
89584ca
Compare
|
All these projects are test projects and should not be changed. I'm withdrawing this PR. |
It was done using a "Quick Fix" and the value set (UTF-8) is the same value that any other project in the workspace uses. The objective of this commit is to declutter the "Problems" view.