Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23] Markdown doc comments with codeblock don't parse Javadoc tags afterwards #2989 #1665

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jarthana
Copy link
Member

@jarthana jarthana commented Sep 20, 2024

Test case for the jdt.core fix

What it does

Fixes eclipse-jdt/eclipse.jdt.core#2980

How to test

Author checklist

@jarthana
Copy link
Member Author

The build failed because the new unstable I builds are not yet part of the composite. Will check once again tomorrow.

@akurtakov
Copy link
Contributor

akurtakov commented Sep 20, 2024

The build failed because the new unstable I builds are not yet part of the composite. Will check once again tomorrow.

There will be no I-build published(to the composite repo) until eclipse-platform/eclipse.platform.releng.aggregator#2358 is resolved.

@jarthana
Copy link
Member Author

The build failed because the new unstable I builds are not yet part of the composite. Will check once again tomorrow.

There will be no I-build published until eclipse-platform/eclipse.platform.releng.aggregator#2358 is resolved.

I recall @mpalat mentioning in an offline discussion that the the changes are expected and we should touch the affected bundles to proceed. But I will wait for him to update the relevant issue once he is sure. This particular issue can wait.

afterwards #2989

 Test case for the jdt.core fix
@jarthana jarthana merged commit 66053c1 into eclipse-jdt:master Sep 25, 2024
9 checks passed
@mpalat
Copy link

mpalat commented Sep 25, 2024

I recall @mpalat mentioning in an offline discussion that the the changes are expected and we should touch the affected bundles to proceed. But I will wait for him to update the relevant issue once he is sure. This particular issue can wait.

I guess no comment required here now as that issue is fixed :). Thanks @jarthana for waiting.

jarthana added a commit to jarthana/eclipse.jdt.ui that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[23] Markdown doc comments with codeblock don't parse Javadoc tags afterwards
3 participants