Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with unsupported target options in compiler preferences #1572

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

iloveeclipse
Copy link
Member

After we dropped support of Java < 1.8 compliance level, we still have to deal with projects that have these setting stored in preferences.

  • Make sure we don't allow use unsupported compliance from JRE < 1.8
  • Make sure we update value of compliance/source and target to first supported version

See #1465

After we dropped support of Java < 1.8 compliance level, we still have
to deal with projects that have these setting stored in preferences.

- Make sure we don't allow use unsupported compliance from JRE < 1.8
- Make sure we update value of compliance/source and target to first
supported version

See eclipse-jdt#1465
@iloveeclipse
Copy link
Member Author

Before change

Considering existing Java 1.7 project settings, following will be shown and after "Apply" all values would be set to 1.7 (even if they show 1.8):

image

After change
Considering Java 1.7 project settings, following will be shown and after "Apply" all values would be set to 1.8 (as expected):

image

@iloveeclipse iloveeclipse merged commit 95a365f into eclipse-jdt:master Aug 7, 2024
9 checks passed
@iloveeclipse iloveeclipse deleted the issue_1465 branch August 7, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant