Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsoleted compiler options from UI code #1571

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Remove obsoleted compiler options from UI code #1571

merged 1 commit into from
Aug 7, 2024

Conversation

iloveeclipse
Copy link
Member

  • Inline finally blocks (larger class files, but improved performance) (JavaCore.COMPILER_CODEGEN_INLINE_JSR_BYTECODE)
  • Disallow identifiers called 'assert' (JavaCore.COMPILER_PB_ASSERT_IDENTIFIER)
  • Disallow identifiers called 'enum' (JavaCore.COMPILER_PB_ENUM_IDENTIFIER)

See #1465

@iloveeclipse
Remove obsoleted compiler options from UI code
7f2a768 
- Inline finally blocks (larger class files, but improved performance)
(JavaCore.COMPILER_CODEGEN_INLINE_JSR_BYTECODE)
- Disallow identifiers called 'assert'
(JavaCore.COMPILER_PB_ASSERT_IDENTIFIER)
- Disallow identifiers called 'enum'
(JavaCore.COMPILER_PB_ENUM_IDENTIFIER)

See eclipse-jdt#1465
@iloveeclipse
Copy link
Member Author

Before: options there but disabled

image

After: options gone

image

@iloveeclipse iloveeclipse merged commit c48f110 into eclipse-jdt:master Aug 7, 2024
9 checks passed
@iloveeclipse iloveeclipse deleted the issue_1465 branch August 7, 2024 16:11
@iloveeclipse iloveeclipse mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iloveeclipse