Issue with code fence > 3 in markdown comment #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarthana
added a commit
to jarthana/eclipse.jdt.ui
that referenced
this pull request
Sep 25, 2024
Test case for eclipse-jdt/eclipse.jdt.core#3006 Also by: Stephan Herrmann <[email protected]>
3 tasks
jarthana
added a commit
to jarthana/eclipse.jdt.ui
that referenced
this pull request
Sep 25, 2024
Test case for eclipse-jdt/eclipse.jdt.core#3006 Also by: Stephan Herrmann <[email protected]>
jarthana
added a commit
to jarthana/eclipse.jdt.ui
that referenced
this pull request
Sep 25, 2024
Test case for eclipse-jdt/eclipse.jdt.core#3006 Also by: Stephan Herrmann <[email protected]>
...core.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/IMarkdownCommentHelper.java
Show resolved
Hide resolved
....core.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java
Show resolved
Hide resolved
|
I have no idea why the build is failing. Only theory I can think of is the compilation pref has changed somehow (tycho?). |
This: is used only inside javadoc, so if javadoc analysis doesn't find the reference, then it will be marked as unused. Did anyone just change javadoc analysis? ;-P |
|
OK, I see that setting the linePtr indiscriminately is wrong. Will take a look. |
|
Something's messed up in my last commit that undid the changes to one file. This needs another attempt. |
jarthana
added a commit
to jarthana/eclipse.jdt.ui
that referenced
this pull request
Oct 1, 2024
Test case for eclipse-jdt/eclipse.jdt.core#3006 Also by: Stephan Herrmann <[email protected]>
jarthana
added a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this pull request
Oct 1, 2024
Test case for eclipse-jdt/eclipse.jdt.core#3006 Also by: Stephan Herrmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #3004
How to test
Author checklist