Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP vanilla identity conversion on Switch #2867

Draft
wants to merge 4 commits into
base: BETA_JAVA23
Choose a base branch
from

Conversation

mpalat
Copy link
Contributor

@mpalat mpalat commented Aug 28, 2024

WIP - DO NOT MERGE

What it does

How to test

Author checklist

stephan-herrmann and others added 4 commits August 27, 2024 15:30
Preparation: + expose isMarkdown in DOM Javadoc

related to eclipse-jdt#2851
Restore ability to format Java in file with markdown comments:
+ avoid AssertionError in TokenManager.firstIndexIn
  visit(Javadoc) need to look for TokenNameCOMMENT_MARKDOWN specifically
+ fix infinite loop in tokenizeMultilineComment()
  - detect markdown comment
  - search for '/' not '*'
  - token should not include the final '\n'

Leave markdown comments unchanged by formatting for now

related to eclipse-jdt#2851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants