[23] Parsing details for markdown comments #2824 #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: since in DOM tests we cannot see how code block is handled in the end, I will add corresponding tests also to org.eclipse.jdt.ui.tests.hover.MarkdownCommentTests. |
+ codeblock cannot interrupt a paragraph + separate handling of code blocks indented vs fenced + fence does not terminate indented code block fixes eclipse-jdt#2824
stephan-herrmann
force-pushed
the
markdown_codeBlocks_2
branch
from
aa78902
to
31052e2
Compare
stephan-herrmann
changed the title
+ escaping of [] inside reference fixes eclipse-jdt#2824
+ code in different fences fixes eclipse-jdt#2824
stephan-herrmann
added a commit
to stephan-herrmann/eclipse.jdt.ui
that referenced
this pull request
Aug 19, 2024
stephan-herrmann
added a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this pull request
Aug 19, 2024
+ more tests along eclipse-jdt/eclipse.jdt.core#2831 fixes #1472
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[]inside references (method arguments)fixes #2824