Switch to make some operations rely on DOM instead of ECJ #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
changed the title
mickaelistria
force-pushed
the
dom-based-operations
branch
from
68f0523
to
0c11b2a
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
from
14408eb
to
1656b25
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
5 times, most recently
from
48eebfc
to
7052ee5
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
8 times, most recently
from
4330a3f
to
edba7c2
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
4 times, most recently
from
5a5ca09
to
7649a67
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
2 times, most recently
from
3c2413d
to
cb01ee7
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
5 times, most recently
from
f984518
to
b4bd774
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
9 times, most recently
from
8ebcc50
to
b5f5f0a
Compare
mickaelistria
force-pushed
the
dom-based-operations
branch
from
15cb481
to
57d72da
Compare
Introduced 2 system property switches to control whether some IDE operations are using ECJ parser (legacy/default) or whether to make those operations powered by a full DOM. * CompilationUnit.DOM_BASED_OPERATIONS will make codeSelect (hover, link to definition...), buildStructure (JDT Project element model), reconciler (code diagnostics feedback); this one seems currently working ✔ * CompilationUnit.codeComplete.DOM_BASED_OPERATIONS controls completion (unlike other operations, completion based on DOM is far from being complete or straightforward) 🏗️ * SourceIndexer.DOM_BASED_INDEXER controls whether the indexation of a source document should first build/use a full DOM. This one is currently incomplete 🏗️ The DOM-based operation can then allow to plug alternative compiler then ECJ and still get JDT functionalities working. Also-By: David Thompson <[email protected]> Also-By: Snjezana Peco <[email protected]>
The parser used to build AST isn't recovering as well as the selection parser. Let's disable those at the moment. They can be re-enabled is the parser used by ASTParser is made to recover better. Some other tests related to particular bugs in JDT are also skipped for the moment. We can't leverage Assume.assume... and skipped tests because those tests run with JUnit 3
mickaelistria
force-pushed
the
dom-based-operations
branch
from
554670c
to
e7c36d3
Compare
|
We won't work further on making JDT's DOM-first approach fully compatible with ECJ. It would still be a nice-to-have, but the remaining issues are hard to fix in ECJ and are not a requirement to fix them in order to enable alternative compiler backends, so no further work in planned on this topic. DOM-first is now fully included with DOM with Javac branch. |
|
FWIW, I'll probably rewrite this patch to not include the implementation, but just have an extension point allowing to define alternative startegies for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(continuation of #1863 as the source repo/branch changed)
Switch to make some operations rely on DOM instead of ECJ
Introduced 2 system property switches to control whether some IDE
operations are using ECJ parser (legacy/default) or whether to make
those operations powered by a full DOM.
The DOM-based operation can then allow to plug alternative compiler then ECJ and still get JDT functionalities working.