Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23] Parsing details for markdown comments #2824

Closed
stephan-herrmann opened this issue Aug 14, 2024 · 0 comments
Closed

[23] Parsing details for markdown comments #2824

stephan-herrmann opened this issue Aug 14, 2024 · 0 comments
Assignees
@stephan-herrmann
Milestone
BETA_JAVA23

Comments

@stephan-herrmann
Copy link
Contributor

stephan-herrmann commented Aug 14, 2024 •
edited
Loading

Part of #2429:

  • ensure code blocks are detected only (a) at the beginning of a comment, or (b) after a blank line
  • proper escaping of array syntax [] within links (see [#meth(String[])])
  • check handling of different styles of code fences
  • ...
@stephan-herrmann stephan-herrmann self-assigned this Aug 14, 2024
@stephan-herrmann stephan-herrmann added this to the BETA_JAVA23 milestone Aug 14, 2024
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Aug 17, 2024
@stephan-herrmann
[23] Parsing details for markdown comments eclipse-jdt#2824
31052e2 
+ codeblock cannot interrupt a paragraph
+ separate handling of code blocks indented vs fenced
  + fence does not terminate indented code block

fixes eclipse-jdt#2824
@stephan-herrmann stephan-herrmann mentioned this issue Aug 17, 2024
Merged
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Aug 18, 2024
@stephan-herrmann
[23] Parsing details for markdown comments eclipse-jdt#2824
b219429 
+ escaping of [] inside reference

fixes eclipse-jdt#2824
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Aug 18, 2024
@stephan-herrmann
[23] Parsing details for markdown comments eclipse-jdt#2824
fcaceb5 
+ code in different fences

fixes eclipse-jdt#2824
stephan-herrmann added a commit that referenced this issue Aug 18, 2024
@stephan-herrmann
[23] Parsing details for markdown comments #2824 (#2831)
9b33f16 
+ codeblock cannot interrupt a paragraph
+ separate handling of code blocks indented vs fenced
  + fence does not terminate indented code block
  + handle various forms of fences:
     - ` vs. ~
     - different fence lengths
     - no mixed fences
     - fences inside fenced region
+ handle (and require) escaping of [ ] inside references (method arguments)

fixes #2824
@stephan-herrmann stephan-herrmann mentioned this issue Aug 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephan-herrmann stephan-herrmann

Labels
None yet
Projects
None yet
Milestone
BETA_JAVA23
Development

No branches or pull requests
1 participant
@stephan-herrmann