Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on minimal target change to 1.8 #2761

Open
5 of 12 tasks
iloveeclipse opened this issue Jul 25, 2024 · 0 comments
Open
5 of 12 tasks

Follow up on minimal target change to 1.8 #2761

iloveeclipse opened this issue Jul 25, 2024 · 0 comments
Labels
compiler Eclipse Java Compiler (ecj) related issues help wanted Extra attention is needed

Comments

@iloveeclipse
Copy link
Member

iloveeclipse commented Jul 25, 2024

Open TODO's from #2551

Created issues:

Following questions wait for answering by others:

  • [Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
  • [Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
  • [Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
    • the test implies to test AST at JLS8
    • using source from project Converter, Converter15, however, selects the AST level from the project.
      @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Eclipse Java Compiler (ecj) related issues help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant