You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
[Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
[Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
the test implies to test AST at JLS8
using source from project Converter, Converter15, however, selects the AST level from the project. @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?
The text was updated successfully, but these errors were encountered:
Open TODO's from #2551
Created issues:
-extdirs
for target 8 #2755CompilerOptions.OPTION_InlineJsr
&CompilerOptions.inlineJsrBytecode
in 4.34 release #2759Following questions wait for answering by others:
this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE);
be used inConverterTestSetup.setUpJavaProject(String, String)
?BatchCompilerTest.testBridgeMethodRetention
This change probably conflicts with the purpose of this test, @srikanth-sankaran ?ASTConverterTestAST8_2.test0612()
caught me by surprise so I investigated:Converter
,Converter15
, however, selects the AST level from the project.@srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used
Converter*
project, e.g.,ASTConverterAST3Test
?The text was updated successfully, but these errors were encountered: