Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECF: Compiling for Java version '1.5' is no longer supported. #220

Open
jukzi opened this issue Aug 12, 2024 · 8 comments
Open

ECF: Compiling for Java version '1.5' is no longer supported. #220

jukzi opened this issue Aug 12, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@jukzi
Copy link
Contributor

jukzi commented Aug 12, 2024

Hello again. Trying to setup a platform workspace from scratch with OOmph as described in https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md results in a workspace with many compilation errors. The root cause seems to be

Compiling for Java version '1.5' is no longer supported. Minimal supported version is '1.8'	BaseID.java	/org.eclipse.ecf.identity/src/org/eclipse/ecf/core/identity	line 0	Java Problem

image

It seems that even JDT can not compile itself anymore
Compiling for Java version '1.2' is no longer supported. Minimal supported version is '1.8' List.java /converterJclMin/src/java/awt line 0 Java Problem
image

@jukzi jukzi added the bug Something isn't working label Aug 12, 2024
@jukzi
Copy link
Contributor Author

jukzi commented Aug 12, 2024

probably related to eclipse-jdt/eclipse.jdt.core#2761

@merks
Copy link
Contributor

merks commented Aug 12, 2024

Have you done a pull on the ecf clone?

@merks
Copy link
Contributor

merks commented Aug 12, 2024

Sorry wrong concern 🙁. Is everything pulled? I’ve not seen this and keep my sdk ide up to date.

@merks
Copy link
Contributor

merks commented Aug 12, 2024

I guess you meant the subject prefix to be ecj not ecf.

Note that this appears to be project content problems not setup problems so be sure you have the latest content. I can't check until late in the day.

@jukzi
Copy link
Contributor Author

jukzi commented Aug 12, 2024

@merks I did clone everything from scratch. So ECF is up to date. As far as i understand ECJ does not compile projects anymore that try to compile for 1.5 but ECF still configured to compile for 1.5 - see https://github.com/search?q=repo%3Aeclipse%2Fecf%20org.eclipse.jdt.core.compiler.compliance%3D1.5&type=code
@iloveeclipse what is the plan for (almost unmaintained) projects that still build for old java versions?

@merks
Copy link
Contributor

merks commented Aug 12, 2024

If this missed something

https://github.com/eclipse/ecf/pull/121/files

It would be best to open an ECF issue or pr for it.

@merks
Copy link
Contributor

merks commented Aug 12, 2024

It looks like there is major confusion here:

image

It's all switched to Java 17.

But wait, there's the java compiler settings as well:

image

Those are not properly updated. So confusing and error prone...

@merks
Copy link
Contributor

merks commented Aug 12, 2024

Seems like competing PRs. That was not intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants