Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#42] Add acl feature flag and deactive it by default #43

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 15, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #2

@elfenpiff elfenpiff self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #43 (6d04921) into main (04e367f) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 6d04921 differs from pull request most recent head 6ac8c70. Consider uploading reports for the commit 6ac8c70 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   77.76%   77.88%   +0.12%     
==========================================
  Files         173      171       -2     
  Lines       19086    18638     -448     
==========================================
- Hits        14842    14516     -326     
+ Misses       4244     4122     -122     
Files Coverage Δ
iceoryx2-bb/posix/src/directory.rs 62.18% <ø> (ø)
iceoryx2-bb/posix/src/file.rs 64.97% <ø> (ø)
iceoryx2-bb/posix/src/file_descriptor.rs 74.78% <ø> (-2.21%) ⬇️
iceoryx2-pal/posix/src/linux/types.rs 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

elBoberido
elBoberido previously approved these changes Dec 15, 2023
@elfenpiff elfenpiff merged commit b8485d3 into eclipse-iceoryx:main Dec 15, 2023
4 of 18 checks passed
@elfenpiff elfenpiff deleted the iox2-42-add-acl-feature-flag branch December 15, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants