Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#370] domain separation example #373

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Sep 6, 2024

Notes for Reviewer

  • example that demonstrates how to create iceoryx2 groups/domains that are isolated

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #370

@elfenpiff elfenpiff self-assigned this Sep 6, 2024
@elfenpiff elfenpiff changed the title [#370] domain separation example [BASED ON 367] [#370] domain separation example Sep 6, 2024
@elfenpiff elfenpiff force-pushed the iox2-370-domain-separation-example branch 2 times, most recently from 7b01ee2 to da38d55 Compare September 10, 2024 07:33
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (b4b8d9c) to head (fdd3ac1).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   79.48%   79.50%   +0.02%     
==========================================
  Files         193      193              
  Lines       22716    22716              
==========================================
+ Hits        18055    18061       +6     
+ Misses       4661     4655       -6     

see 3 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-370-domain-separation-example branch from da38d55 to fdd3ac1 Compare September 11, 2024 11:42
@elfenpiff elfenpiff changed the title [BASED ON 367] [#370] domain separation example [#370] domain separation example Sep 11, 2024
@orecham
Copy link
Contributor

orecham commented Sep 12, 2024

LGTM


// The domain name becomes the prefix for all resources.
// Therefore, different domain names never share the same resources.
config.global.prefix = FileName::new(args.domain.as_bytes())?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this line is the only significant change that users need to make to leverage this feature. Nice and simple.

@elfenpiff elfenpiff merged commit 2fe0403 into eclipse-iceoryx:main Sep 13, 2024
54 of 55 checks passed
@elfenpiff elfenpiff deleted the iox2-370-domain-separation-example branch September 13, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants