-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#370] domain separation example #373
[#370] domain separation example #373
Conversation
7b01ee2
to
da38d55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 79.48% 79.50% +0.02%
==========================================
Files 193 193
Lines 22716 22716
==========================================
+ Hits 18055 18061 +6
+ Misses 4661 4655 -6 |
da38d55
to
fdd3ac1
Compare
LGTM |
|
||
// The domain name becomes the prefix for all resources. | ||
// Therefore, different domain names never share the same resources. | ||
config.global.prefix = FileName::new(args.domain.as_bytes())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this line is the only significant change that users need to make to leverage this feature. Nice and simple.
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Unit tests have been written for new behaviorPublic API is documentedPost-review Checklist for the PR Author
References
Relates to #370