Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#361] creation timeout #363

Merged
merged 15 commits into from
Sep 2, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Aug 30, 2024

Notes for Reviewer

From previous PR:
How about calling this cpu_core_participant_1 and cpu_core_participant_2. We could then use the same names for the multi-process benchmark.

In the PR we check if the version number is equal zero to additionally determine if the shared memory was initialized or not. Technically it is undefined behavior but works most of the time since the OS zero's the memory. A cleaner solution would be to apply the access rights strategy to the trampoline files but this will cost a lot of effort. Here is the tracking issue for that: #364

In this PR I would pursue the version flag approach since it offers a solution and pursue the #364 later.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #361

@elfenpiff elfenpiff self-assigned this Aug 30, 2024
@elfenpiff elfenpiff force-pushed the iox2-361-creation-timeout branch 2 times, most recently from 1400ff8 to c984380 Compare August 30, 2024 17:46
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 82.71605% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (6089d60) to head (4f6b3ba).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...yx2-cal/src/dynamic_storage/posix_shared_memory.rs 50.00% 8 Missing ⚠️
iceoryx2/src/service/builder/mod.rs 73.33% 8 Missing ⚠️
iceoryx2-cal/src/static_storage/file.rs 84.00% 4 Missing ⚠️
iceoryx2-cal/src/static_storage/process_local.rs 85.71% 4 Missing ⚠️
iceoryx2-cal/src/shared_memory/common.rs 90.90% 2 Missing ⚠️
iceoryx2-cal/src/zero_copy_connection/common.rs 94.11% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   80.12%   80.20%   +0.07%     
==========================================
  Files         193      193              
  Lines       22702    22723      +21     
==========================================
+ Hits        18191    18224      +33     
+ Misses       4511     4499      -12     
Files with missing lines Coverage Δ
iceoryx2-cal/src/static_storage/mod.rs 77.77% <ø> (ø)
iceoryx2-cal/src/zero_copy_connection/mod.rs 12.50% <ø> (ø)
iceoryx2/src/node/mod.rs 70.92% <100.00%> (ø)
iceoryx2/src/port/details/publisher_connections.rs 100.00% <100.00%> (ø)
...ceoryx2/src/port/details/subscriber_connections.rs 94.80% <100.00%> (+0.06%) ⬆️
iceoryx2/src/service/builder/event.rs 81.27% <ø> (+0.57%) ⬆️
iceoryx2/src/service/builder/publish_subscribe.rs 89.68% <ø> (+0.33%) ⬆️
iceoryx2/src/service/mod.rs 79.00% <100.00%> (-1.53%) ⬇️
iceoryx2-cal/src/shared_memory/common.rs 86.38% <90.90%> (+1.10%) ⬆️
iceoryx2-cal/src/zero_copy_connection/common.rs 92.01% <94.11%> (+0.40%) ⬆️
... and 4 more

... and 4 files with indirect coverage changes

@elfenpiff elfenpiff merged commit b67e09a into eclipse-iceoryx:main Sep 2, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation waiting timeout is set to zero
2 participants