-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#361] creation timeout #363
Merged
elfenpiff
merged 15 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-361-creation-timeout
Sep 2, 2024
Merged
[#361] creation timeout #363
elfenpiff
merged 15 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-361-creation-timeout
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfenpiff
force-pushed
the
iox2-361-creation-timeout
branch
2 times, most recently
from
August 30, 2024 17:46
1400ff8
to
c984380
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
==========================================
+ Coverage 80.12% 80.20% +0.07%
==========================================
Files 193 193
Lines 22702 22723 +21
==========================================
+ Hits 18191 18224 +33
+ Misses 4511 4499 -12
|
elBoberido
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
From previous PR:
How about calling this
cpu_core_participant_1
andcpu_core_participant_2
. We could then use the same names for the multi-process benchmark.In the PR we check if the version number is equal zero to additionally determine if the shared memory was initialized or not. Technically it is undefined behavior but works most of the time since the OS zero's the memory. A cleaner solution would be to apply the access rights strategy to the trampoline files but this will cost a lot of effort. Here is the tracking issue for that: #364
In this PR I would pursue the version flag approach since it offers a solution and pursue the #364 later.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #361