Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#350] Extend dynamic config API #352

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Aug 13, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #350

@elfenpiff elfenpiff self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (ec6f906) to head (b013e16).

Files Patch % Lines
iceoryx2/src/service/dynamic_config/event.rs 0.00% 16 Missing ⚠️
...x2/src/service/dynamic_config/publish_subscribe.rs 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   80.37%   80.29%   -0.08%     
==========================================
  Files         192      192              
  Lines       22537    22569      +32     
==========================================
+ Hits        18113    18121       +8     
- Misses       4424     4448      +24     
Files Coverage Δ
iceoryx2/src/service/dynamic_config/event.rs 78.82% <0.00%> (-18.28%) ⬇️
...x2/src/service/dynamic_config/publish_subscribe.rs 78.82% <0.00%> (-18.28%) ⬇️

... and 5 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 959da91 into eclipse-iceoryx:main Aug 14, 2024
46 of 48 checks passed
@elfenpiff elfenpiff deleted the iox2-350-extended-dynamic-config-api branch August 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend dynamic config API
2 participants