Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for namespace packages #306

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Jul 12, 2024


Description

Adds a decision record that describes how valid Aspect Model namespace packages
are structured.

Fixes #305.

Type of change

Please delete options that are not relevant.

  • Decision record
  • [-] Bug fix (non-breaking change which fixes an issue)
  • [-] New feature (non-breaking change which adds functionality)
  • [-] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [-] My code follows the style guidelines of this project
  • [-] I have performed a self-review of my own code
  • [-] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [-] My changes generate no new warnings
  • [-] I have added tests that prove my fix is effective or that my feature works

@atextor atextor force-pushed the 305-specify-namespace-packages branch from 3267492 to df7afc5 Compare July 12, 2024 14:27
@atextor atextor force-pushed the 305-specify-namespace-packages branch from df7afc5 to b04e0ad Compare July 12, 2024 14:28
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@external-Bogdan-Toma
Copy link

I see no problem in switching to the new API and removing our in house zip handling. Some zip validation cases from catalog will be handled by sdk and some by catalog (or maybe all by sdk).

@atextor atextor merged commit 34237ad into eclipse-esmf:main Aug 13, 2024
2 checks passed
@atextor atextor deleted the 305-specify-namespace-packages branch August 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Specify model/namespace packages
5 participants