Clarify usage of AbstractEntity as datatype #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atextor
changed the title
…idate by the AbstractEntityDirectlyInstantiated shape
Yauhenikapl
approved these changes
Jan 5, 2024
Yauhenikapl
reviewed
Jan 5, 2024
There was a problem hiding this comment.
I am not sure that we have to add here this, because meta-model version 2.0.0 we will not release.
But as documentation - good!
Yauhenikapl
reviewed
Jan 5, 2024
There was a problem hiding this comment.
I am not sure that we have to add here this, because meta-model version 2.1.0 we will not release.
But as documentation - good!
atextor
requested changes
Jan 15, 2024
...ntic-aspect-meta-model/src/main/resources/samm/meta-model/2.2.0/aspect-meta-model-shapes.ttl
Outdated
Show resolved
Hide resolved
...cteristic-shape/org.eclipse.esmf.test/1.0.0/TestCharacteristicInstanceWithEntityDataType.ttl
Outdated
Show resolved
Hide resolved
...c-shape/org.eclipse.esmf.test/1.0.0/TestCharacteristicInstanceWithAbstractEntityDataType.ttl
Outdated
Show resolved
Hide resolved
...cteristic-shape/org.eclipse.esmf.test/1.0.0/TestCharacteristicInstanceWithEntityDataType.ttl
Outdated
Show resolved
Hide resolved
...cteristic-shape/org.eclipse.esmf.test/1.0.0/TestCharacteristicInstanceWithEntityDataType.ttl
Show resolved
Hide resolved
...e.esmf.test/1.0.0/TestCharacteristicInstanceWithDirectInstantiatedAbstractEntityDataType.ttl
Outdated
Show resolved
Hide resolved
...cteristic-shape/org.eclipse.esmf.test/1.0.0/TestCharacteristicInstanceWithEntityDataType.ttl
Outdated
Show resolved
Hide resolved
...esmf.test/1.0.0/TestCharacteristicInstanceWithExtendedInstantiatedAbstractEntityDataType.ttl
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Textor <[email protected]>
…//github.com/bci-oss/esmf-semantic-aspect-meta-model into bug/clarify-usage-abstractentity-as-datatype
atextor
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #187
This requirement:
A shape must make sure that if an instance is created of a Characteristic that uses an Abstract Entity as its type, this Characteristic instance's dataType must be a concrete sub-Entity the Abstract Entity.seems to be corresponded by the shape samm:AbstractEntityDataTypeShape. Please check again.