Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation fixes eclipse-esmf/esmf-sdk-py-aspect-model-load… #44

Conversation

thec0dewriter
Copy link

@thec0dewriter thec0dewriter commented Jul 25, 2024

…er#43

Description

added a first implementation mainly based on the Enum implementation, given it's an enum with a default value.
Maybe a better option would be to reuse the enum implementation

Fixes #43

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

Add any other notes or comments here.

Copy link
Contributor

@atextor atextor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thec0dewriter,
thanks a lot for your contribution! It seems the beginning of the PR description is cut off, you might want to change it.
In order for us to be able to merge your PR, you need to sign the Eclipse Contributor Agreement (ECA). Please note that your Eclipse account needs to be registered with the same email address you used to create the commit(s). After you've done this, the check on the PR called "eclipsefdn/eca" should be green.

@thec0dewriter thec0dewriter deleted the #43-state-initiator-implementation branch August 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing state_initiator implementation
2 participants