Add a test to check element resolving #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yauhenikapl
approved these changes
Feb 13, 2024
atextor
requested changes
Feb 13, 2024
| @prefix type: <urn:samm:com.bosch.test.type:0.2.0#> . | ||
| @prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.0.0#> . | ||
|
|
||
| :ProcessParameters a samm:Aspect ; |
There was a problem hiding this comment.
Please use a neutral Aspect Model name
| # Copyright (c) 2023 Robert Bosch Manufacturing Solutions GmbH, Germany. All rights reserved. | ||
| # | ||
|
|
||
| @prefix : <urn:samm:com.bosch.test.models:0.2.0#>. |
There was a problem hiding this comment.
The test namespace should be urn:samm:org.eclipse.esmf.test:1.0.0#
| # | ||
|
|
||
| @prefix : <urn:samm:com.bosch.test.models:0.2.0#>. | ||
| @prefix type: <urn:samm:com.bosch.test.type:0.2.0#> . |
There was a problem hiding this comment.
If this needs to be in another namspace than the default test namespace, it should be included in it, e.g. urn:samm:org.eclipse.esmf.test.other:1.0.0#
| @prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.0.0#> . | ||
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| :processedPartId a samm:Property ; |
There was a problem hiding this comment.
Please use a neutral model element name
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| :processedPartId a samm:Property ; | ||
| samm:preferredName "Processed Part ID"@en ; |
There was a problem hiding this comment.
Adapt to neutral element name
| @prefix samm-c: <urn:samm:org.eclipse.esmf.samm:characteristic:2.0.0#> . | ||
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| :materialNumber a samm:Property ; |
There was a problem hiding this comment.
Please use neutral model element name
| @prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
|
|
||
| :materialNumber a samm:Property ; | ||
| samm:preferredName "Material Number"@en ; |
|
|
||
| :materialNumber a samm:Property ; | ||
| samm:preferredName "Material Number"@en ; | ||
| samm:preferredName "Materialnummer"@de ; |
| :materialNumber a samm:Property ; | ||
| samm:preferredName "Material Number"@en ; | ||
| samm:preferredName "Materialnummer"@de ; | ||
| samm:description "The identification of the product based on the SAP material number."@en ; |
| samm:preferredName "Material Number"@en ; | ||
| samm:preferredName "Materialnummer"@de ; | ||
| samm:description "The identification of the product based on the SAP material number."@en ; | ||
| samm:exampleValue "F03Z12345602" ; |
atextor
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: